![]() If the idea is OK there are still 2 qestions to answer:ġ. Helper (_xchg(&x, 0)), which is the same as private helper inī) C++ : 'exchange' from utility header. Presence of similar helpers in other somehow related languages/libs:Ī) Rust: 'replace' from std::mem module, there is also 'take' + previous_min_rate = _xchg(evport->qos.min_rate, min_rate) įor sure the code is more compact, and IMHO more readable.Ģ. previous_min_rate = evport->qos.min_rate ![]() ![]() Real example from drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c: Code readability/simplification/number of lines: I want to present few arguments why it would be good to have it:ġ. The helper is tiny and there are advices we can leave without it, so This is the 2nd approach of the same idea, with comments addressed. So I've used my intuition to construct to/cc lists, sorry for mistakes. I am not sure who is good person to review/ack such patches, Quick cocci analyze shows there is probably few thousands places I hope there will be place for such tiny helper in kernel. Linux-sh, sparclinux, linux-xtensa, intel-gfx, dri-develĬc: Andrzej Hajda, Arnd Bergmann, Rodrigo Vivi, Andrew Morton,Īndy Shevchenko, Peter Zijlstra, Boqun Feng, Mark Rutland Openrisc, linux-parisc, linuxppc-dev, linux-riscv, linux-s390, Linux-hexagon, linux-ia64, loongarch, linux-m68k, linux-mips, To: linux-alpha, linux-kernel, linux-snps-arc, linux-arm-kernel, ` (20 more replies) 0 siblings, 21 replies 41+ messages in threadįrom: Andrzej Hajda 11:46 UTC ( / raw) 11:46 ` arch/alpha: rename internal name _xchg to _arch_xchg Andrzej Hajda Comes with Full numeric keypad and a gold-plated corrosion free USB connector for a reliable connection.Introduce _xchg, non-atomic xchg archive mirror help / color / mirror / Atom feed * Introduce _xchg, non-atomic xchg 11:46 Andrzej Hajda Featuring, 12 multimedia keys, 12 programmable macro keys, USB passthrough, volume control, Non-Slip Ergonomic, splash-proof Design. BACKLIT ANTI GHOSTING KEYBOARD ALL 131 mechanical gaming keyboards keys are conflict free (n-Key Rollover) for ultimate Gaming performance.(The key switches are user replaceable)The detachable wrist rest gives you the comfort you need for marathon gaming sessions. Plate-mounted mechanical keys and switches that stand up to tough gaming conditions. QUICK DETACHABLE WRIST REST AND SOLID BLACK ALUMINUM / ABS CONSTRUCTION The PC Gaming keyboard is constructed of Aircraft-Grade Aluminum.Featuring a Total of 18 Backlight Modes, 8 different colors, 5 backlight brightness levels, breathing speed, and 6 dedicated keys to program user defined backlighting. RGB MECHANICAL KEYBOARD WITH 12Programmable MACRO KEYS K550 Yama Redragon RGB Backlit Mechanical Gaming Keyboard, the RGB Led illuminated keyboard comes with Double-shot injection molded keycaps offering crystal clear uniform backlighting and lettering that doesn't scratch off.Ideal for both ultimate Gaming performance andfor office environments, where a too loud clicky sound might annoy others. The Mechanical Keyboard Keys offer medium resistance, medium click sound, and crisp, precise tactile feedback. GAMING KEYBOARD BLACK 104 Key Mechanical Gaming Keyboard with Custom Mechanical Switches designed for longevity with greater durability and responsiveness.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |